Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building free-threaded wheels #2315

Closed
ngoldbaum opened this issue Nov 20, 2024 · 4 comments · Fixed by #2310
Closed

Support building free-threaded wheels #2315

ngoldbaum opened this issue Nov 20, 2024 · 4 comments · Fixed by #2310
Labels
enhancement New feature or request

Comments

@ngoldbaum
Copy link
Contributor

While working on crate-py/rpds#101 I discovered that maturin can't build free-threaded wheels:

± maturin build --target aarch64-apple-darwin --release --out dist --interpreter 3.9 3.10 3.11 3.12 3.13 3.13t pypy3.9 pypy3.10
📦 Including license file "/Users/goldbaum/Documents/rpds-py/LICENSE"
🔗 Found pyo3 bindings
⚠️  Warning: skipped unavailable python interpreter 'pypy3.10' from pyenv
💥 maturin failed
  Caused by: Invalid python interpreter minor version '13t', expect a digit
  Caused by: invalid digit found in string

I'm not sure if there are other issues besides that there isn't a UI to do this, I don't know much about how maturin works.

It might be helpful to look at what @henryiii and @mayeut did to get cibuildwheel working with the free-threaded build: pypa/cibuildwheel#1831

@davidhewitt
Copy link
Member

This is already underway in #2310 😁

@davidhewitt
Copy link
Member

@messense is there anything remaining to do before this can be released? I'm happy to offer help if there is, would love to see a free-threaded compatible maturin so that we can start shipping 🛥️

@messense
Copy link
Member

Opened #2322

@davidhewitt
Copy link
Member

🙏 amazing, thanks!

messense pushed a commit that referenced this issue Nov 27, 2024
Related to #2315 

As of `maturin` 1.7.5 we accept `maturin build -i python3.13t` for the
free-threaded build, it seems like we might want to allow `maturin build
-i 3.13t` (and assume CPython).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants