Fix sdist build for optional path dependencies #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for maturin-guide canceled.
|
messense
force-pushed
the
fix-optional-path-deps
branch
from
db6a1df to
15f6b3e
Compare
messense
force-pushed
the
fix-optional-path-deps
branch
from
15f6b3e to
21ab189
Compare
|
This does not work actually, build from sdist fails $ cargo build
error: failed to load manifest for dependency `polars`
Caused by:
failed to load manifest for dependency `polars-algo`
Caused by:
failed to read `/Users/messense/Projects/maturin/dist/polars-0.14.9/local_dependencies/polars/polars-algo/Cargo.toml`
Caused by:
No such file or directory (os error 2) |
messense
commented
Sep 6, 2022
| // Cargo.toml contains relative paths, and we're already in LOCAL_DEPENDENCIES_FOLDER | ||
| toml_edit::value(format!("../{}", dep_name)) | ||
| }; | ||
| rewritten = true; | ||
| if !known_path_deps.contains_key(&dep_name) { |
There was a problem hiding this comment.
Because of #1084 (comment), I think we need to somehow add the optional path deps to known_path_deps even if they're not activated by Cargo features.
There was a problem hiding this comment.
Unfortunately there isn't enough metadata:
"dependencies": [
{
"name": "polars-algo",
"source": null,
"req": "^0.23.0",
"kind": null,
"rename": null,
"optional": true,
"uses_default_features": true,
"features": [],
"target": null,
"registry": null,
"path": "/Users/messense/Projects/polars/polars/polars-algo"
}
]and the optional polars-algo dep isn't present at packages, thus we can only get its name and path, but we also need it's id which is unavailable.
There was a problem hiding this comment.
This reminds me of #720 (comment), we might be able to workaround this by using dependencies instead of the structured dep.
2 tasks
Co-authored-by: Maximilian Köhl <mail@koehlma.de>
messense
force-pushed
the
fix-optional-path-deps
branch
from
fd2a4b3 to
eb909d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1083 by also bundling optional path dependencies.