Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PEP 517 config_settings support #1619

Merged
merged 1 commit into from
May 20, 2023
Merged

Add PEP 517 config_settings support #1619

merged 1 commit into from
May 20, 2023

Conversation

messense
Copy link
Member

Replaces MATURIN_PEP517_ARGS environment variable with --config-settings build-args=<cargo build args>.

Closes #1541

@netlify
Copy link

netlify bot commented May 20, 2023 •
edited
Loading

✅ Deploy Preview for maturin-guide ready!

Name Link
🔨 Latest commit 1fdaebc
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/64684f7725a04b000807984c
😎 Deploy Preview https://deploy-preview-1619--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@messense
Add PEP 517 config_settings support
1fdaebc 
Replaces `MATURIN_PEP517_ARGS` environment variable with
`--config-settings build-args=<cargo build args>`.
@messense messense requested a review from konstin May 20, 2023 04:41
@konstin
Copy link
Member

konstin commented May 20, 2023

I like replacing environment variables with a PEP mechanism!

Do the frontends most users use (e.g. pip, python -m build, tox and nox) all support --config-settings? If yes, deprecating MATURIN_PEP517_ARGS is the right thing to do, if no, i'd keep both MATURIN_PEP517_ARGS and --config-settings without any deprecation.

@messense
Copy link
Member Author

pip and python -m build has direct support for --config-settings, nox can pass --config-settings or any other options in session.install, tox needs to use a customized install_command to add --config-settings I think.

@messense messense added this pull request to the merge queue May 20, 2023
@messense messense removed this pull request from the merge queue due to a manual request May 20, 2023
@messense messense merged commit f66a0c8 into PyO3:main May 20, 2023
@messense messense deleted the config-settings branch May 20, 2023 14:39
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request May 21, 2023
@bmwiedemann
Update python-maturin to version 0.15.3 / rev 30 via SR 1088131
43f762c 
https://build.opensuse.org/request/show/1088131
by user mia + dimstar_suse
- Update to v0.15.3:
  * Fix cross-compile to Apple universal2 in the other platform
    gh#PyO3/maturin#1613
  * Remove serde(flatten) to improve error messages
    gh#PyO3/maturin#1616
  * Allow syn 2.0
    gh#PyO3/maturin#1617
  * describe the need for module-name
    gh#PyO3/maturin#1604
  * Add PEP 517 config_settings support
    gh#PyO3/maturin#1619
  * Keep file mode on Unix
    gh#PyO3/maturin#1622
- Changes in v0.15.2:
  * Remove bors
    gh#PyO3/maturin#1602
  * When determining the python module name, use pyproject.toml
    project.name over Cargo.toml package.name.
    gh#PyO3/maturin#1608
  * Warn on missing python-source contents
    gh#PyO3/maturin#1607
  * Fix rewriting dev-dependencies in sdist
    gh#PyO3/maturin#1610
@messense messense mentioned this pull request Sep 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstin konstin konstin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PEP 517 config_settings support
2 participants
@messense @konstin