-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change mixed rust/python template project layout #855
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Deploy Preview for maturin-guide canceled. 🔨 Explore the source changes: 3ed0dd9 🔍 Inspect the deploy log: https://app.netlify.com/sites/maturin-guide/deploys/623078ef1d9f9b0008f66bd3 |
This was referenced Jun 15, 2022
MusicalNinjaDad
added a commit
to MusicalNinjaDad/FizzBuzz
that referenced
this pull request
May 13, 2024
MusicalNinjaDad
added a commit
to MusicalNinjaDad/FizzBuzz
that referenced
this pull request
May 13, 2024
move python packages to dedicated python directory as per PyO3/maturin#855
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion-python
that referenced
this pull request
May 14, 2024
… projects The previous layout leads to an import error when installing with `maturin build` and `pip install .`. This error was common enough that `maturin` changed the recommended project layout to what this commit does. A prior PR attempted to solve this by altering `lib.name` in Cargo.toml, but that did not work for me. - [Prior PR](apache#694) - [maturin ImportError issue](PyO3/maturin#490) - [maturin changes recommended project structure](PyO3/maturin#855)
andygrove
pushed a commit
to apache/datafusion-python
that referenced
this pull request
May 14, 2024
#695) * chore: update to maturin's recommended project layout for rust/python projects The previous layout leads to an import error when installing with `maturin build` and `pip install .`. This error was common enough that `maturin` changed the recommended project layout to what this commit does. A prior PR attempted to solve this by altering `lib.name` in Cargo.toml, but that did not work for me. - [Prior PR](#694) - [maturin ImportError issue](PyO3/maturin#490) - [maturin changes recommended project structure](PyO3/maturin#855) * ci: update `ruff check` for nested python directory
hohav
added a commit
to hohav/peppi-py
that referenced
this pull request
Jul 6, 2024
Per PyO3/maturin#490 and PyO3/maturin#855, this avoids problems when importing from the project dir.
hohav
added a commit
to hohav/peppi-py
that referenced
this pull request
Jul 6, 2024
Per PyO3/maturin#490 and PyO3/maturin#855, this avoids problems when importing from the project dir.
hohav
added a commit
to hohav/peppi-py
that referenced
this pull request
Jul 6, 2024
Per PyO3/maturin#490 and PyO3/maturin#855, this avoids problems when importing from the project dir.
hohav
added a commit
to hohav/peppi-py
that referenced
this pull request
Jul 8, 2024
Per PyO3/maturin#490 and PyO3/maturin#855, this avoids problems when importing from the project dir.
hohav
added a commit
to hohav/peppi-py
that referenced
this pull request
Jul 15, 2024
Per PyO3/maturin#490 and PyO3/maturin#855, this avoids problems when importing from the project dir.
hohav
added a commit
to hohav/peppi-py
that referenced
this pull request
Aug 1, 2024
Per PyO3/maturin#490 and PyO3/maturin#855, this avoids problems when importing from the project dir.
mlondschien
added a commit
to mlondschien/changeforest
that referenced
this pull request
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #335 (comment)
Before:
After: