Optimize parsing with attr.path.is_ident()

PyO3 · Jan 30, 2023 · 25fe971 · 25fe971
1 parent e21fb3f
commit 25fe971
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 10 deletions.
diff --git a/pyo3-macros-backend/src/attributes.rs b/pyo3-macros-backend/src/attributes.rs
@@ -195,12 +195,13 @@ pub fn take_pyo3_options<T: Parse>(attrs: &mut Vec<Attribute>) -> Result<Vec<T>>
             }
             Ok(false)
         };
-        if let Ok(mut meta) = attr.parse_meta() {
-            if handle_cfg_feature_pyo3(&mut attr, &mut meta, parse_attr)? {
-                continue;
+        if attr.path.is_ident("cfg_attr") {
+            if let Ok(mut meta) = attr.parse_meta() {
+                if handle_cfg_feature_pyo3(&mut attr, &mut meta, parse_attr)? {
+                    continue;
+                }
             }
         }
-
         if let Some(options) = get_pyo3_options(&attr)? {
             out.extend(options.into_iter());
             continue;

diff --git a/pyo3-macros-backend/src/konst.rs b/pyo3-macros-backend/src/konst.rs
@@ -70,13 +70,18 @@ impl ConstAttributes {
 
         for mut attr in attrs.drain(..) {
             let parse_attr = |meta, _attr: &Attribute| parse_attribute(&mut attributes, &meta);
-            if let Ok(mut meta) = attr.parse_meta() {
-                if handle_cfg_feature_pyo3(&mut attr, &mut meta, parse_attr)? {
-                    continue;
-                }
+            if attr.path.is_ident("cfg_attr")
+                || attr.path.is_ident("classattr")
+                || attr.path.is_ident("pyo3")
+            {
+                if let Ok(mut meta) = attr.parse_meta() {
+                    if handle_cfg_feature_pyo3(&mut attr, &mut meta, parse_attr)? {
+                        continue;
+                    }
 
-                if parse_attribute(&mut attributes, &meta)? {
-                    continue;
+                    if parse_attribute(&mut attributes, &meta)? {
+                        continue;
+                    }
                 }
             }
             new_attrs.push(attr)