Hack __text_signature__ back to working with abi3 #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
force-pushed
the
abi3-text-signature
branch
from
bcef541 to
4e70273
Compare
|
This gross hack seems to break PyPy -- not a big surprise. I guess I'll just disable it there. |
alex
force-pushed
the
abi3-text-signature
branch
from
4e70273 to
36ddd9e
Compare
kngwyu
approved these changes
Sep 19, 2020
tests/test_text_signature.rs
Outdated
Comment on lines
70
to
71
| // Ignored because heap types don't have working __text_signature__: | ||
| // https://github.com/python/cpython/blob/master/Objects/typeobject.c#L864-L870 |
alex
force-pushed
the
abi3-text-signature
branch
from
36ddd9e to
9d85591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.