msrv: bump to 1.45 #1272
Merged
msrv: bump to 1.45 #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
force-pushed
the
bump-msrv
branch
from
3257173
to
9617edf
Compare
kngwyu
approved these changes
Nov 12, 2020
| } else { | ||
| (None, args) | ||
| match args { | ||
| [py, args @ ..] if utils::is_python(&py.ty) => (Some(py), args), |
kngwyu
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps minimum supported Rust version to 1.45.
I think there's a few places now where the older Rust version is beginning to hold us up, and also RHEL now supports Rust 1.45: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8/html/8.3_release_notes/overview
From #1269 I discovered that maturin needs MSRV 1.40
In #1270 the usage of
const fnthere needs a slightly newer compiler than 1.39 (not sure exactly which one).Closes #1252
Closes #1262