Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffi cleanup: pylifecycle to pystate #1823

Merged
merged 4 commits into from
Aug 24, 2021
Merged

ffi cleanup: pylifecycle to pystate #1823

merged 4 commits into from
Aug 24, 2021

Conversation

deantvv
Copy link
Contributor

@deantvv deantvv commented Aug 23, 2021

For #1289

@deantvv deantvv marked this pull request as draft August 23, 2021 13:22
davidhewitt
davidhewitt requested changes Aug 23, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

I have a few concerns about the pystate bindings, commented below. Everything else looks great and correct!

src/ffi/pystate.rs Outdated Show resolved Hide resolved
src/ffi/pystate.rs Outdated Show resolved Hide resolved
src/ffi/pystate.rs Outdated Show resolved Hide resolved
src/ffi/pystate.rs Outdated Show resolved Hide resolved
src/ffi/pystate.rs Outdated Show resolved Hide resolved
src/ffi/cpython/pystate.rs Show resolved Hide resolved
src/ffi/pylifecycle.rs Outdated Show resolved Hide resolved
@deantvv
Copy link
Contributor Author

deantvv commented Aug 24, 2021

@davidhewitt I got it almost all wrong because I wrongly use the old branch which caused a lot of unnecessary trouble. Thanks for carefully reviewing the code! Wish I won't get it wrong the next time.

davidhewitt
davidhewitt approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 not a problem at all, mistakes happen! I just try to give PRs thorough reviews so that the PyO3 codebase is as correct as possible 😄

This new patch looks great to me, thanks very much for helping clean all this up!

@davidhewitt davidhewitt marked this pull request as ready for review August 24, 2021 20:15
@davidhewitt davidhewitt merged commit 2df0cb6 into PyO3:main Aug 24, 2021
@deantvv deantvv deleted the ffi-cleanup branch August 25, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deantvv @davidhewitt