ffi cleanup: pystrtod to pythonrun #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deantvv
force-pushed
the
ffi-cleanup-0825
branch
from
a146f14 to
8615c63
Compare
|
Thanks, looks like a great tidy up! For all APIs removed in Python 3.10 can you use |
deantvv
force-pushed
the
ffi-cleanup-0825
branch
2 times, most recently
from
ba8b071 to
530b086
Compare
Done and also update changelog. |
deantvv
force-pushed
the
ffi-cleanup-0825
branch
2 times, most recently
from
e98d73b to
1819733
Compare
davidhewitt
approved these changes
Aug 26, 2021
deantvv
force-pushed
the
ffi-cleanup-0825
branch
from
1819733 to
dbbcf9d
Compare
deantvv
force-pushed
the
ffi-cleanup-0825
branch
2 times, most recently
from
f5e6fa5 to
c871390
Compare
Move multiple limited api to cpython. Many API in `pythonrun` are removed in python 3.10. There is also some function and macro share the same name (documented below) in cpython, which I choose to skip macro definition. - PyRun_String - PyRun_AnyFile - PyRun_AnyFileEx - PyRun_AnyFileFlags
deantvv
force-pushed
the
ffi-cleanup-0825
branch
from
c871390 to
7322056
Compare
davidhewitt
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1289
Move multiple limited api to cpython. Many API in
pythonrunareremoved in python 3.10. For a reminder, I add comment "will be removed
in 3.10" for that.
There is also some function and macro share the same name (documented
below) in cpython, which I choose to skip macro definition.