[DO NOT MERGE] [#2359]Add macro append_to_inittab #2362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
reviewed
May 10, 2022
There was a problem hiding this comment.
Thanks. It's actually very hard to use #krate in function-like proc macros.
You might want to take a look at #2363 and rebase on top of it? Then you should be able to write a macro_rules macro in the same way as those wrap macros.
pyo3-ffi/src/import.rs
Outdated
| @@ -76,6 +76,6 @@ extern "C" { | |||
|
|
|||
| pub fn PyImport_AppendInittab( | |||
| name: *const c_char, | |||
| initfunc: Option<extern "C" fn() -> *mut PyObject>, | |||
There was a problem hiding this comment.
#2363 looks like a better approach. I will wait until that is merged.
|
Sorry I did a u-turn and will proceed with #2363 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we need to debug in a real environment with our module installed.
append_to_inittabwill be a wrapper for PyImport_AppendInittab (https://docs.python.org/3/c-api/import.html#c.PyImport_AppendInittab) and help us to do thisSo far I'm not sure how to use
#kratein macro rather than hard codedpyo3. I wonder if anyone have any suggestion how to achieve this?