Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advantages
The main reason I'm proposing this is because 0.4 doesn't compile on recent nightly due to a compiler bug. We'd also get all improvements deployed.
Disadvantages
The current master contains only have the breaking I wanted to have as neither specialization nor
PyToken
are completely purged yet. This means at least I will be making breaking changes soon after 0.5.0 and the release after that will have to be another semver major, meaning extra upgrade work for all downstream crates.