Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use older hashbrown and indexmap for MSRV #3546

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

davidhewitt
Copy link
Member

Ok, I think this is the solution which will finally work to resolve the ahash break.

If it's good, I'll merge it and push the other PRs through which are blocked on merging by this.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Oct 24, 2023
@davidhewitt davidhewitt enabled auto-merge October 24, 2023 20:53
@davidhewitt davidhewitt added this pull request to the merge queue Oct 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2023
@davidhewitt
Copy link
Member Author

I've added a commit to allow nightly jobs to fail, which should let this merge. It's happened a few times that nightly breaks with upstream changes, so I think this is justified. I'll fix the nightly break in a follow up PR.

@davidhewitt davidhewitt enabled auto-merge October 25, 2023 07:36
@davidhewitt davidhewitt added this pull request to the merge queue Oct 25, 2023
Merged via the queue into PyO3:main with commit de6162f Oct 25, 2023
33 of 34 checks passed
@davidhewitt davidhewitt deleted the older-hashbrown branch October 25, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant