Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversion between chrono_tz::Tz and zoneinfo.ZoneInfo #3730

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversion between chrono_tz::Tz and zoneinfo.ZoneInfo #3730

merged 1 commit into from
Jan 15, 2024

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented Jan 8, 2024 •
edited
Loading

Issue #3266

@Tpt Tpt force-pushed the chrono-tz branch 3 times, most recently from 7cac6fa to 2df6533 Compare January 8, 2024 10:29
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 8, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3730 will degrade performances by 10.38%

Comparing Tpt:chrono-tz (72f0c73) with main (4b17287)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 76 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main Tpt:chrono-tz Change
⚡ list_via_extract 303.3 ns 275.6 ns +10.08%
❌ getattr_direct 9.1 µs 10.2 µs -10.38%

@Tpt Tpt force-pushed the chrono-tz branch 3 times, most recently from dd2f668 to de59cb8 Compare January 8, 2024 14:17
@Tpt
Copy link
Contributor Author

Tpt commented Jan 8, 2024

CI fails because of a more aggressive dead_code lint

Tpt
Tpt commented Jan 8, 2024
View reviewed changes
Cargo.toml
@@ -35,6 +35,7 @@ inventory = { version = "0.3.0", optional = true }
# crate integrations that can be added using the eponymous features
anyhow = { version = "1.0", optional = true }
chrono = { version = "0.4.25", default-features = false, optional = true }
chrono-tz = { version = ">= 0.6, < 0.9", default-features = false, optional = true }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to make sure we are compatible with MSRV

davidhewitt
davidhewitt approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks consistent with the other conversions based on pure-python types e.g. ip address. So I'm happy with this to merge as-is 👍

@davidhewitt davidhewitt added this pull request to the merge queue Jan 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 11, 2024
@davidhewitt davidhewitt added this pull request to the merge queue Jan 15, 2024
Merged via the queue into PyO3:main with commit 7366b1a Jan 15, 2024
36 of 38 checks passed
@Tpt Tpt deleted the chrono-tz branch February 1, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tpt @davidhewitt