-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port PyComplex::from_complex
to Bound
API
#3866
Conversation
CodSpeed Performance ReportMerging #3866 will degrade performances by 10.2%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me too! Just one thing I spotted which maybe we should add here...
@@ -283,7 +283,7 @@ pub(crate) mod bytes; | |||
pub(crate) mod capsule; | |||
#[cfg(not(Py_LIMITED_API))] | |||
mod code; | |||
mod complex; | |||
pub(crate) mod complex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops we missed PyComplexMethods
from the prelude too, mind adding at the same time please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Added it in another commit.
Part of #3684
This ports the
PyComplex::from_complex
constructor of thenum-complex
interop to theBound
API