Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature gate deprecated APIs for PyDict #4108

Merged
merged 1 commit into from
Apr 23, 2024
Merged

feature gate deprecated APIs for PyDict #4108

merged 1 commit into from
Apr 23, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Apr 22, 2024

Part of #3960

Move deprecated PyDict APIs behind gil-refs features gate.

@Icxolu Icxolu added the CI-skip-changelog Skip checking changelog entry label Apr 22, 2024
@Icxolu Icxolu mentioned this pull request Apr 22, 2024
Closed
51 tasks
davidhewitt
davidhewitt approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I hope to find some time to join in with making these updates soon...

@davidhewitt davidhewitt added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2024
@Icxolu Icxolu added this pull request to the merge queue Apr 23, 2024
Merged via the queue into PyO3:main with commit 5d2f5b5 Apr 23, 2024
43 of 44 checks passed
@Icxolu Icxolu deleted the pydict branch April 23, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Icxolu @davidhewitt