Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement PartialEq for Pybool & bool #4305

Merged
merged 4 commits into from
Jul 5, 2024
Merged

implement PartialEq for Pybool & bool #4305

merged 4 commits into from
Jul 5, 2024

Conversation

Owen-CH-Leung
Copy link
Contributor

This PR implements PartialEq for Pybool with bool. See #4250

@Owen-CH-Leung Owen-CH-Leung marked this pull request as ready for review July 3, 2024 05:56
LilyFoote
LilyFoote reviewed Jul 3, 2024
View reviewed changes
src/types/boolobject.rs Outdated Show resolved Hide resolved
@Owen-CH-Leung Owen-CH-Leung mentioned this pull request Jul 4, 2024
Open
davidhewitt
davidhewitt approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks!

@davidhewitt davidhewitt added this pull request to the merge queue Jul 5, 2024
Merged via the queue into PyO3:main with commit 5860c4f Jul 5, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyFoote LilyFoote LilyFoote approved these changes

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Owen-CH-Leung @LilyFoote @davidhewitt