Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unintentional unsafe_op_in_unsafe_fn trigger #4674

Merged
merged 2 commits into from
Nov 2, 2024
Merged

fix unintentional unsafe_op_in_unsafe_fn trigger #4674

merged 2 commits into from
Nov 2, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Oct 31, 2024

Closes #4663

Adjusts our expansion to comply with unsafe_op_in_unsafe_fn and adjusts the spans to prevent unsafe_code to trigger.

@Icxolu Icxolu added the bugfix label Oct 31, 2024
davidhewitt
davidhewitt approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nicely done 👍

@davidhewitt davidhewitt added this pull request to the merge queue Nov 2, 2024
Merged via the queue into PyO3:main with commit fdb29cc Nov 2, 2024
44 checks passed
@Icxolu Icxolu deleted the fix/4663 branch November 2, 2024 12:51
@Icxolu Icxolu mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#[pymethods] generated code triggers unsafe_op_in_unsafe_fn lint
2 participants
@Icxolu @davidhewitt