Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy::wildcard_import firing on #[pyclass] #4707

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Icxolu
Copy link
Contributor

@Icxolu Icxolu commented Nov 14, 2024

Closes #4701

@Icxolu Icxolu added bugfix CI-skip-changelog Skip checking changelog entry labels Nov 14, 2024
@Icxolu
Copy link
Contributor Author

Icxolu commented Nov 14, 2024

I guess this does not need a changelog because it worked on 0.22?

@Icxolu
Copy link
Contributor Author

Icxolu commented Nov 14, 2024

Also not sure if we have a way to test this. I could not make it error on ui or hygiene tests.

Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I think this is fine, I couldn't find a way to make it error either.

Thanks for fixing, should have guessed it was my janky code 😂

@davidhewitt davidhewitt added this pull request to the merge queue Nov 14, 2024
Merged via the queue into PyO3:main with commit 147f7ef Nov 14, 2024
46 of 48 checks passed
@Icxolu Icxolu deleted the fix/4701 branch November 15, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new wildcard_import clippy warning from #[pyclass] on main
2 participants