Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rasterio reprojection bug. Appears with 1.2.10 #240

Merged
merged 2 commits into from
May 31, 2022

Conversation

pz-max
Copy link
Contributor

@pz-max pz-max commented May 27, 2022

Closes #238 .

The problem and solution are described in issue #238

How Has This Been Tested?

I run pytest before and after the changes. See more about my reproducable testing procedure here -> #238

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I tested my contribution locally and it seems to work fine.
  • I locally ran pytest inside the repository and no unexpected problems came up. (no more than previously existing -> there is one error irrespective of the reprojection stuff)
  • I have adjusted the docstrings in the code appropriately.
  • [NA] I have documented the effects of my code changes in the documentation doc/.
  • I have added newly introduced dependencies to environment.yaml file.
  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution

@pz-max
Copy link
Contributor Author

pz-max commented May 27, 2022

@FabianHofmann the PR is ready to merge

@FabianHofmann FabianHofmann merged commit 3c7b4b8 into PyPSA:master May 31, 2022
@pz-max pz-max mentioned this pull request Jul 30, 2022
8 tasks
@pz-max pz-max mentioned this pull request Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

downsampling results in 0 or 1 raster without float
2 participants