Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend pre-commit yaml #276

Merged
merged 4 commits into from
Feb 22, 2023
Merged

extend pre-commit yaml #276

merged 4 commits into from
Feb 22, 2023

Conversation

FabianHofmann
Copy link
Contributor

@FabianHofmann FabianHofmann commented Feb 22, 2023

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I tested my contribution locally and it seems to work fine.
  • I locally ran pytest inside the repository and no unexpected problems came up.
  • I have adjusted the docstrings in the code appropriately.
  • I have documented the effects of my code changes in the documentation doc/.
  • I have added newly introduced dependencies to environment.yaml file.
  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 72.73% // Head: 72.47% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (ad6c9f5) compared to base (1d9f184).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head ad6c9f5 differs from pull request most recent head 6272e64. Consider uploading reports for the commit 6272e64 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   72.73%   72.47%   -0.26%     
==========================================
  Files          19       19              
  Lines        1588     1595       +7     
  Branches      225      225              
==========================================
+ Hits         1155     1156       +1     
- Misses        363      369       +6     
  Partials       70       70              
Impacted Files Coverage Δ
atlite/pv/solar_panel_model.py 92.30% <ø> (ø)
atlite/__init__.py 100.00% <100.00%> (ø)
atlite/aggregate.py 72.72% <100.00%> (ø)
atlite/convert.py 68.45% <100.00%> (ø)
atlite/csp.py 42.85% <100.00%> (ø)
atlite/cutout.py 72.82% <100.00%> (-2.05%) ⬇️
atlite/data.py 86.74% <100.00%> (ø)
atlite/datasets/__init__.py 100.00% <100.00%> (ø)
atlite/datasets/era5.py 88.59% <100.00%> (ø)
atlite/datasets/gebco.py 40.74% <100.00%> (ø)
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FabianHofmann FabianHofmann merged commit bab679f into master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant