Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing cut-out wind speeds to NREL turbines #317

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

euronion
Copy link
Collaborator

@euronion euronion commented Sep 7, 2023

Partially addresses #314

h/t @joAschauer

Change proposed in this Pull Request

Add cut-out wind speeds to NREL turbines missing a cut-out wind speed

Description

Motivation and Context

missing, bug. Bad.

How Has This Been Tested?

Not tested, same function as other turbines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [] I tested my contribution locally and it seems to work fine.
  • I locally ran pytest inside the repository and no unexpected problems came up.
  • I have adjusted the docstrings in the code appropriately.
  • I have documented the effects of my code changes in the documentation doc/.
  • I have added newly introduced dependencies to environment.yaml file.
  • I have added a note to release notes doc/release_notes.rst.
  • I have used pre-commit run --all to lint/format/check my contribution

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (764d206) 72.31% compared to head (1c097a8) 72.54%.
Report is 1 commits behind head on master.

❗ Current head 1c097a8 differs from pull request most recent head 6957210. Consider uploading reports for the commit 6957210 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   72.31%   72.54%   +0.23%     
==========================================
  Files          19       19              
  Lines        1694     1661      -33     
  Branches      294      284      -10     
==========================================
- Hits         1225     1205      -20     
+ Misses        387      379       -8     
+ Partials       82       77       -5     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FabianHofmann FabianHofmann merged commit 43fd1ad into master Oct 18, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants