Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

era5: update to new CDS infrastructure #364

Merged
merged 2 commits into from
Aug 2, 2024
Merged

era5: update to new CDS infrastructure #364

merged 2 commits into from
Aug 2, 2024

Conversation

fneum
Copy link
Member

@fneum fneum commented Aug 2, 2024

closes #361

This PR is backwards compatible; old CDS infrastructure can still be used.

Other things needed to update:

Main changes:

  • The time variable was renamed in CDS from "time" to "valid_time", which is renamed in _rename_and_clean_coords()
  • A useless "number" coordinate was added, which is removed in _rename_and_clean_coords().
  • There was some weirdness in the "expver" coordinate when ERA5 and ERA5T data were mixed (coordinate but not a dimension). Also, it seems that the "expver" coordinate is now always created and is a 4-digit string rather than an integer. If somebody has a leaner suggestion here, I am all ears. It was quite tricky as non-xarray expert.

If we want to use new CDS infrastructure in CI, the secrets need to be updated. Perhaps we shouldn't do this immediately.

Furthermore, I am not sure how to remove the plentiful INFO logs.

Copy link
Contributor

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand it fully, but looks good

@FabianHofmann FabianHofmann merged commit 5c6d9b5 into master Aug 2, 2024
5 checks passed
@euronion
Copy link
Collaborator

euronion commented Aug 6, 2024

  • Should restrict to new CDSAPI package version
  • Should add migration note in the release notes
  • Should make a new release

I think migrating ASAP makes sense, since the old one will be shutdown in less than a month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to new CDS infrastructure
3 participants