Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically retrieve data directly from source #342

Closed
wants to merge 15 commits into from
Closed

Conversation

fneum
Copy link
Member

@fneum fneum commented Mar 24, 2022

Co-authored-by: euronion 42553970+euronion@users.noreply.github.com

Closes # (if applicable).

Changes proposed in this Pull Request

  • restore Windows compatibility at end
  • delete zips because they are only temporary
  • split Snakefile -> workflow/rules/downloads.smk

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
  • Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes.

 Co-authored-by: euronion <42553970+euronion@users.noreply.github.com>
@fneum fneum changed the title download eez and gebco Automatically retrieve data directly from source Mar 24, 2022
@fneum
Copy link
Member Author

fneum commented Mar 29, 2022

@euronion what was the reason to have the zips as defined outputs? We could also delete those once they were put in right locations.

@euronion
Copy link
Contributor

I had issues initially with using the snakemake.input with unzip .... But with unpack_archive(...) that might actually be obsolete now. You can probably remove the zips

@fneum
Copy link
Member Author

fneum commented Aug 2, 2024

superseded by #1188 and #1190

@fneum fneum closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants