-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate tyndp 2020 #626
Integrate tyndp 2020 #626
Conversation
- add fantasy commissioning year for existing assets (beginning of UNIX time)
…a-eur into integrate-tyndp-2020
- add / change format of some columns in TYNDP df's - refactor code
- building base network works - add warning if asset which is to be upgraded does not exist
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing at the moment. Probably the test config needs adjustments.
Please test locally and add suggested fix.
@@ -257,6 +257,13 @@ conventional: | |||
nuclear: | |||
p_max_pu: "data/nuclear_p_max_pu.csv" # float of file name | |||
|
|||
TYNDP2020: | |||
include: false | |||
allowed_statuses: ['in_permitting', 'under_construction'] # 'planned_not_yet_permitting', 'under_consideration' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better -> allowed_status
upg_lines, | ||
upg_links, | ||
config, | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add here the README tyndp as docstring
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Quick update (probably mostly for my future self): |
…a-eur into integrate-tyndp-2020
for more information, see https://pre-commit.ci
There was one mistake in the line filtering which kicked out many tyndp lines in the base_network script, which @martacki is fixing. |
not yet, still need to do some runs on the cluster to validate this PR |
Related to #57 .
Changes proposed in this Pull Request
In an external repository "tyndp_to_pypsa", coordinates were added to the TYNDP projects by hand based on asset names, the rudimentary maps on the TYNDP website, and OpenStreetMap. The data is converted there to the gridextract format so that it can be imported seamlessly into PyPSA-Eur. It is already split into asset type and "new" or "upgraded" based on the latest gridextract and
links_tyndp.csv
- but this means every time this data changes, the TYNDP files indata/tyndp2020
would have to be rebuilt usingtyndp_to_pypsa
.To test this, follow the usual config file workflow (remember to set
include: true
in the TYNDP2020 options).I have not tested this beyond building the base network (see plot at bottom).
Checklist
config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.under_construction=True
is set in order to conform to the current format. Does this make sense?under_construction=True
is set. I do not know the implications of this, but the updated asset might not remain usable until the commissioning date of the update.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes.