Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Corpus] Include Thai person names directly into the package #297

Merged
merged 4 commits into from
Oct 10, 2019
Merged

[Corpus] Include Thai person names directly into the package #297

merged 4 commits into from
Oct 10, 2019

Conversation

bact
Copy link
Member

@bact bact commented Oct 10, 2019 •
edited
Loading

@bact bact added the corpus corpus/dataset-related issues label Oct 10, 2019
@bact bact added this to the 2.1 milestone Oct 10, 2019
@bact bact self-assigned this Oct 10, 2019
@pep8speaks
Copy link

pep8speaks commented Oct 10, 2019 •
edited
Loading

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-10 02:02:59 UTC

@wannaphong wannaphong mentioned this pull request Oct 10, 2019
Closed
@coveralls
Copy link

coveralls commented Oct 10, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 90.297% when pulling 95adc1f on include-namelist into 8a05a17 on dev.

@bact bact merged commit 6db1921 into dev Oct 10, 2019
@bact bact deleted the include-namelist branch October 10, 2019 02:34
@bact
Copy link
Member Author

bact commented Oct 10, 2019

Updated names are sent back to the main repo: korkeatw/thai-names-corpus#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bact bact

Labels
corpus corpus/dataset-related issues
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bact @pep8speaks @coveralls