-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing and enhancing text normalization funcitons #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bact
commented
May 6, 2020
•
edited
Loading
edited
- Fix: Remove repetitive tone marks - this will partially close Text normalization not working in some cases #384 and Add a more advanced normalize function #374
- Add: Remove zero-width characters - this will close Add a function to remove zero-width characters #373
- Add: Remove duplicate spaces - this will close Add a more advanced normalize function #374
- Add: Remove dangling non-base chars at the beginning of text
- Remove "phantom chars"
bact
changed the title
Fix: normalize() not remove repetitive tonemarks
Fix: normalize() will now remove tone marks repetition
May 6, 2020
I add docs. It's OK. 👍 |
wannaphong
approved these changes
May 7, 2020
Rename remove_phantom() to remove_dangling()
p16i
reviewed
May 8, 2020
bact
changed the title
Fix: normalize() will now remove tone marks repetition
Fixing and enhancing text normalization funcitons
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.