Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add support for Iterable auto dataset + resolve a bug for Preprocess Transforms. #227

Merged
merged 46 commits into from
Apr 19, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Apr 19, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Apr 19, 2021

Hello @tchaton! Thanks for updating this PR.

Line 274:13: W503 line break before binary operator

Line 189:13: W503 line break before binary operator

Comment last updated at 2021-04-19 14:17:03 UTC

@tchaton tchaton self-assigned this Apr 19, 2021
@tchaton tchaton added this to the 0.3 milestone Apr 19, 2021
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #227 (86eaaaf) into master (42cc20a) will decrease coverage by 0.12%.
The diff coverage is 86.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   86.61%   86.49%   -0.13%     
==========================================
  Files          57       57              
  Lines        2750     2829      +79     
==========================================
+ Hits         2382     2447      +65     
- Misses        368      382      +14     
Flag Coverage Δ
unittests 86.49% <86.76%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/model.py 94.04% <55.55%> (-2.18%) ⬇️
flash/data/data_module.py 78.08% <64.28%> (-0.02%) ⬇️
flash/data/utils.py 95.95% <83.33%> (-0.92%) ⬇️
flash/data/data_pipeline.py 87.18% <86.36%> (-0.86%) ⬇️
flash/data/auto_dataset.py 94.23% <90.00%> (-2.02%) ⬇️
flash/data/process.py 86.74% <95.45%> (+2.32%) ⬆️
flash/core/classification.py 100.00% <100.00%> (ø)
flash/vision/classification/data.py 87.74% <100.00%> (-0.06%) ⬇️
flash/vision/detection/data.py 94.26% <100.00%> (-0.82%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42cc20a...86eaaaf. Read the comment docs.

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

self,
data: Union[Iterable, Any],
running_stage: RunningStage = None,
use_iterable_auto_dataset: bool = False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use_iterable_auto_dataset: bool = False
use_iterable_auto_dataset: bool = False,

@tchaton tchaton merged commit 781fa98 into master Apr 19, 2021
@tchaton tchaton deleted the iterable_auto_dataset branch April 19, 2021 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants