Mocking Loggers (part 3b, comet) #3853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* mock comet * new line
|
This pull request is now in conflict... :( |
Codecov Report
@@ Coverage Diff @@
## master #3853 +/- ##
======================================
- Coverage 88% 88% -0%
======================================
Files 117 117
Lines 9132 9129 -3
======================================
- Hits 7992 7989 -3
Misses 1140 1140 |
justusschock
approved these changes
Oct 5, 2020
|
It is a early stop / checkpointing test failing, but comes from master. Have not investigated yet. |
SkafteNicki
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes after #3851
Part 2 of comet mocking, step by step
this is needed to consistently mock the logger
split in smaller parts in order to keep PRs managable and easy to review.