Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hparams assign in init #4189

Merged
merged 1 commit into from
Oct 16, 2020
Merged

fix hparams assign in init #4189

merged 1 commit into from
Oct 16, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 16, 2020

What does this PR do?

adding saving hparams even without using save_hyperparameters just with hard assign in class init (any fist init...)

Fixes #4179
Fixes #4186

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working feature Is an improvement or enhancement priority: 0 High priority task labels Oct 16, 2020
@mergify mergify bot requested a review from a team October 16, 2020 07:54
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #4189 into master will increase coverage by 3%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #4189    +/-   ##
=======================================
+ Coverage      90%     93%    +3%     
=======================================
  Files         103     103            
  Lines        7842    7844     +2     
=======================================
+ Hits         7053    7277   +224     
+ Misses        789     567   -222     

@mergify mergify bot requested a review from a team October 16, 2020 08:44
@SeanNaren SeanNaren merged commit 3fe479f into master Oct 16, 2020
@Borda Borda deleted the feature/hparams branch October 16, 2020 13:49
@Borda Borda added this to the 1.0.x milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature Is an improvement or enhancement priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.0.2 doesn't log hyper parameters Hparams are not automatically saved to WandB logger in 1.0.2
4 participants