Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate prefix argument in ModelCheckpoint #4765

Merged
merged 7 commits into from
Nov 21, 2020
Merged

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Nov 18, 2020

What does this PR do?

Deprecated prefix argument in ModelCheckpoint. It's no longer needed since we have filename now in ModelCheckpoint.
#4557 (comment)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #4765 (a26c9d8) into master (69b9949) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4765   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         117     117           
  Lines        8974    8977    +3     
======================================
+ Hits         8347    8350    +3     
  Misses        627     627           

@gdhdgy
Copy link

gdhdgy commented Nov 19, 2020

ت

@SkafteNicki SkafteNicki added ready PRs ready to be merged logger Related to the Loggers labels Nov 20, 2020
@rohitgr7 rohitgr7 added checkpointing Related to checkpointing and removed logger Related to the Loggers labels Nov 20, 2020
@rohitgr7 rohitgr7 added this to the 1.0.8 milestone Nov 20, 2020
@Borda Borda modified the milestones: 1.0.8, 1.0.x Nov 20, 2020
@rohitgr7 rohitgr7 merged commit db69d16 into master Nov 21, 2020
@rohitgr7 rohitgr7 deleted the deprecate/mc_prefix branch November 21, 2020 12:38
rohitgr7 added a commit that referenced this pull request Nov 21, 2020
* Deprecate prefix in ModelCheckpoint

* chlog

Co-authored-by: chaton <thomas@grid.ai>
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@Borda Borda modified the milestones: 1.0.x, 1.1 Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants