-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: clean trainer device & distrib setters #5297
Conversation
Hello @Borda! Thanks for updating this PR.
Comment last updated at 2021-01-04 16:06:42 UTC |
dffc408
to
ff74854
Compare
so it seems we had a bug there... :D
yes, that is why I change only setting and not reading in this PR and no tests shall be changed either... |
@SeanNaren mind check why the parity params are different for ddp_cpu?
|
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5297 +/- ##
================================================
- Coverage 93% 91% -2%
================================================
Files 144 146 +2
Lines 10146 10417 +271
================================================
+ Hits 9425 9516 +91
- Misses 721 901 +180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So ddp_cpu
can now only work if we set the number of processes above 1, and if specified automatically allocate all CPU resources. I think this is fine, just ensuring there is no case where we'd like to keep the current behaviour!
happy to verify, but no idea when you do not want to use max resources...? |
What does this PR do?
Fixes # (issue) <- this links related issue to this PR
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃