-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix trainer distributed attributes #5303
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5303 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 142 142
Lines 10028 10028
===============================================
Hits 9307 9307
Misses 721 721 |
Why do we need the |
yes, but the enum does not like being compared with None... but let's try it again... 🐰 |
Should work: from enum import Enum
class Foo(Enum):
BAR = "bar"
print(None == Foo.BAR) # False
`` |
yes, just tried in the past commit c618ee0 |
What does this PR do?
Fixing typos in exist check...
Fixes #4990
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃