Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trainer distributed attributes #5303

Merged
merged 4 commits into from
Dec 31, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 30, 2020

What does this PR do?

Fixing typos in exist check...
Fixes #4990

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working priority: 0 High priority task labels Dec 30, 2020
@Borda Borda added this to the 1.2 milestone Dec 30, 2020
@codecov
Copy link

codecov bot commented Dec 30, 2020

Codecov Report

Merging #5303 (c618ee0) into release/1.2-dev (2094633) will not change coverage.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5303   +/-   ##
===============================================
  Coverage               93%     93%           
===============================================
  Files                  142     142           
  Lines                10028   10028           
===============================================
  Hits                  9307    9307           
  Misses                 721     721           

@Borda Borda self-assigned this Dec 30, 2020
@carmocca
Copy link
Contributor

Why do we need the is not None checks? == works for None

@Borda
Copy link
Member Author

Borda commented Dec 30, 2020

Why do we need the is not None checks? == works for None

yes, but the enum does not like being compared with None... but let's try it again... 🐰
anyway, it is just a deprecation solution :]

@Borda Borda requested a review from rohitgr7 December 30, 2020 19:38
@carmocca
Copy link
Contributor

yes, but the enum does not like being compared with None

Should work:

from enum import Enum

class Foo(Enum):
    BAR = "bar"

print(None == Foo.BAR)  # False
``

@Borda
Copy link
Member Author

Borda commented Dec 30, 2020

Should work:

from enum import Enum

class Foo(Enum):
    BAR = "bar"

print(None == Foo.BAR)  # False
``

yes, just tried in the past commit c618ee0
not sure how it happened that it was crashing in past... :/

@Borda Borda added the ready PRs ready to be merged label Dec 30, 2020
@Borda Borda merged commit 73e06fd into release/1.2-dev Dec 31, 2020
@Borda Borda deleted the bugfix/trainer-distrib-attrib branch December 31, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants