ref: clean config [1/n] add intermediate setters #4990

Borda · 2020-12-06T16:29:00Z

What does this PR do?

preparation step for cleaning the distributed and device logic...

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
Did you make sure to update the documentation with your changes?
Did you write any new necessary tests?
Did you verify new and existing tests pass locally with your changes?
If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

pep8speaks · 2020-12-06T16:29:05Z

Hello @Borda! Thanks for updating this PR.

In the file pytorch_lightning/accelerators/accelerator.py:

Line 259:1: W391 blank line at end of file

In the file pytorch_lightning/trainer/deprecated_api.py:

Line 126:17: W503 line break before binary operator
Line 127:17: W503 line break before binary operator

Comment last updated at 2020-12-09 19:11:03 UTC

tchaton

LGTM ! Happy to finally see this part being cleaned out !

Borda · 2020-12-06T18:18:56Z

the failing static type checking was introduced in another PR...

Borda · 2020-12-06T18:30:05Z

@williamFalcon mind review?
note it does not change any logic nor calls, this shall be done in followup PR

codecov · 2020-12-06T19:16:42Z

Codecov Report

Merging #4990 (ecb2081) into master (20b806a) will increase coverage by 0%.
The diff coverage is 96%.

@@           Coverage Diff           @@
##           master   #4990    +/-   ##
=======================================
  Coverage      93%     93%            
=======================================
  Files         132     133     +1     
  Lines        9832    9943   +111     
=======================================
+ Hits         9109    9215   +106     
- Misses        723     728     +5

pytorch_lightning/utilities/__init__.py

pytorch_lightning/trainer/deprecated_api.py

justusschock · 2020-12-07T08:33:25Z

@Borda we should decide whether we want to go with uppercase naming or not and be consistent with it.

Borda · 2020-12-07T08:44:30Z

@Borda we should decide whether we want to go with uppercase naming or not and be consistent with it.

ok, I would then go with the upper case as it is easy to convert (compare to mix like DDP_spawn) and apply with most cases

Edit: I have added a feature that the comparison is invariant, would it be better? @justusschock

pytorch_lightning/utilities/__init__.py

tests/trainer/test_trainer.py

pytorch_lightning/accelerators/accelerator.py

tchaton · 2020-12-09T18:08:42Z

pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py

@@ -21,6 +21,12 @@


 class LoggerStages(str, Enum):


Can you use LightningEnum everywhere ?

commit f374782c65ff01f9814457c707b214698b0f27c6 Author: gianscarpe <gianluca@scarpellini.dev> Date: Tue Dec 15 18:28:21 2020 +0100 Rebasing onto master commit 84bb9db Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Mon Dec 14 22:46:14 2020 +0100 simplify changelog (Lightning-AI#5135) commit 69123af Author: Tadej Svetina <tadej.svetina@gmail.com> Date: Mon Dec 14 20:13:58 2020 +0100 Fix hanging metrics tests (Lightning-AI#5134) commit eb9cb3c Author: Shachar Mirkin <shacharmirkin@gmail.com> Date: Mon Dec 14 13:39:29 2020 +0100 Add Google Colab badges (Lightning-AI#5111) * Add colab badges to notebook Add colab badges to notebook to notebooks 4 & 5 * Add colab badges Co-authored-by: chaton <thomas@grid.ai> commit 0327f6b Author: Carlos Mocholí <carlossmocholi@gmail.com> Date: Mon Dec 14 08:38:10 2020 +0100 Do not warn when the name key is used in the lr_scheduler dict (Lightning-AI#5057) * Do not warn when the name key is used * Missing line * Consistency * Update pytorch_lightning/callbacks/lr_monitor.py * Update docs * Update pytorch_lightning/core/lightning.py Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * Update CHANGELOG Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> commit 16feb51 Author: tarepan <tarepan5884@gmail.com> Date: Mon Dec 14 01:13:50 2020 +0900 Refactor load in checkpoint connector (Lightning-AI#4593) * Refactor load step commentaries * Refactor hpc ckpt suffix acquisition * Refactor restore/hpc_load match * Refactor hpc load trial * Refactor checkpoint dir check * Refactor unneeded function nest * Refactor nested If * Refactor duplicated cache clear * Refactor attempt flow with if/elif * Fix pip8 * Refactor hook commentary Co-authored-by: chaton <thomas@grid.ai> * Fix pep8 * Refactor hpc load checkpoint path acquisition * Fix pip8 * Fix doc Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> * Refactor None Union type with Optional Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> commit 398f122 Author: Carlos Mocholí <carlossmocholi@gmail.com> Date: Sun Dec 13 16:04:16 2020 +0100 Improve some tests (Lightning-AI#5049) * Improve some tests * Add TrainerState asserts Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> commit a49291d Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Sat Dec 12 17:21:19 2020 +0100 drop unused test with result api (Lightning-AI#5058) Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> commit b50ad9e Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Sat Dec 12 15:55:11 2020 +0100 split tests for deprecated api (Lightning-AI#5071) * imports * imports * flake8 Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> commit 3100b78 Author: Rohit Gupta <rohitgr1998@gmail.com> Date: Sat Dec 12 15:47:03 2020 +0530 Allow any input in to_onnx and to_torchscript (Lightning-AI#4378) * branch merge * sample * update with valid input tensors * pep * pathlib * Updated with BoringModel and added more input types * try fix * pep * skip test with torch < 1.4 * fix test * Apply suggestions from code review * update tests * Allow any input in to_onnx and to_torchscript * Update tests/models/test_torchscript.py Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> * no_grad * try fix random failing test * rm example_input_array * rm example_input_array Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Jeff Yang <ydcjeff@outlook.com> Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com> commit b5a2afd Author: Roger Shieh <sh.rog@protonmail.ch> Date: Sat Dec 12 15:14:17 2020 +0800 Remove beta arg from F1 class and functional (Lightning-AI#5076) * remove beta from F1 * remove from functional Co-authored-by: Teddy Koker <teddy.koker@gmail.com> commit 0de43d1 Author: Roger Shieh <sh.rog@protonmail.ch> Date: Sat Dec 12 14:23:55 2020 +0800 Fix docs metrics formatting (Lightning-AI#5077) * fix functional f1 fbeta formatting * Update f_beta.py * remove line breaks * Update f_beta.py add line breaks and pad * pad linea breaks with 2 spaces instead of tab commit d38e4d1 Author: skhiuk <38586033+Shumpei-Kikuta@users.noreply.github.com> Date: Sat Dec 12 14:00:32 2020 +0900 fix: MNIST minor bug (Lightning-AI#5075) Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> commit 5f34f2b Author: edenlightning <66261195+edenlightning@users.noreply.github.com> Date: Fri Dec 11 20:42:04 2020 -0500 Update installation instructions for FairScale (Lightning-AI#5099) Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> commit 63fb7f9 Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Sat Dec 12 00:17:19 2020 +0100 CI: upload report only on failer (Lightning-AI#5086) * CI: upload report only on failer * Apply suggestions from code review Co-authored-by: chaton <thomas@grid.ai> * Apply suggestions from code review Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> commit 1e501f0 Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Fri Dec 11 22:56:19 2020 +0100 add back compatibility for deprecated metrics 2/n (Lightning-AI#5068) * add back compatibility for deprecated metrics * fix * imports * imports commit 4a3f906 Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Fri Dec 11 22:11:21 2020 +0100 add back compatibility for deprecated metrics 1/n (Lightning-AI#5067) * add back compatibility for metrics * tests * Add deprecated metric utility functions back to functional (Lightning-AI#5062) * add back *deprecated* metric utility functions to functional * pep * pep * suggestions * move Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz> * more * fix * import * docs * tests * fix Co-authored-by: Teddy Koker <teddy.koker@gmail.com> commit ddc3757 Author: chaton <thomas@grid.ai> Date: Fri Dec 11 21:21:25 2020 +0100 Pre release (Lightning-AI#5098) * add rc release * update changelog * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> commit 1a970b2 Author: chaton <thomas@grid.ai> Date: Fri Dec 11 20:24:59 2020 +0100 [hotfix] Extend Optimizer + update doc (Lightning-AI#5095) * resolve urgent bug * update pr * update doc * update * remove typo * add defaults * Update pytorch_lightning/__init__.py * Update setup.py * update doc * Update docs/source/optimizers.rst Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * update * resolve doc * debug test * update test * Update docs/source/optimizers.rst Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> * Update docs/source/optimizers.rst Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> * Update docs/source/optimizers.rst Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> * remove useless import * Update docs/source/optimizers.rst Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> commit 74171ef Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Fri Dec 11 18:42:53 2020 +0100 drop duplicate metrics (Lightning-AI#5014) * drop duplicate metrics * keep * fix commit 7755572 Author: chaton <thomas@grid.ai> Date: Fri Dec 11 14:51:45 2020 +0100 Check if optimizer supports closure (Lightning-AI#4981) * check if optimizer support closure * cleanup test * resolve tests * resolve flake * update test due to patch limit * update * update dep * Update tests/core/test_lightning_optimizer.py Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * Update tests/core/test_lightning_optimizer.py Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * resolve bug * update test * resolve tests * Update requirements/extra.txt Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * remove bolts dep * remove bolts * add missing bolts dep for tests * remove need for bolts Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> commit 4e6a871 Author: Rohit Gupta <rohitgr1998@gmail.com> Date: Fri Dec 11 15:07:32 2020 +0530 Added CHANGELOG section (Lightning-AI#5065) commit 7e8673d Author: Alan Du <alanhdu@gmail.com> Date: Thu Dec 10 12:26:02 2020 -0500 Update DDP docs (Lightning-AI#5046) * Fix flake8 error to fix CI * Correct weights-loading to use correct callbacks * Fix dangling links Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> commit 2c3d43d Author: chaton <thomas@grid.ai> Date: Thu Dec 10 15:24:44 2020 +0100 Initialize trainer with None in DDPAccelerator (Lightning-AI#4915) * Initialize trainer with None * add typing to all accelerators * resolve imports * update * add typing * removed typo * update * Fix formatting and imports in accelerator Co-authored-by: maxjeblick <maxjeblick@users.noreply.github.com> Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> Co-authored-by: SeanNaren <sean@grid.ai> Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> commit d5fa02e Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Thu Dec 10 14:06:13 2020 +0100 simplify accelerator steps (Lightning-AI#5015) * simplify accelerator steps * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> commit 820d5c7 Author: Hemil Desai <hemil.desai10@gmail.com> Date: Thu Dec 10 16:26:18 2020 +0530 Add a notebook example to reach a quick baseline of ~94% accuracy on CIFAR (Lightning-AI#4818) * Add a notebook example to reach a quick baseline of ~94% accuracy on CIFAR10 using Resnet in Lightning * Remove outputs * PR Feedback * some changes * some more changes Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: rohitgr7 <rohitgr1998@gmail.com> commit 4ebce38 Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Thu Dec 10 11:01:33 2020 +0100 update usage of deprecated automatic_optimization (Lightning-AI#5011) * drop deprecated usage automatic_optimization * Apply suggestions from code review Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> commit 77fb425 Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Thu Dec 10 08:38:14 2020 +0100 update usage of deprecated profiler (Lightning-AI#5010) * drop deprecated profiler * lut Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> commit cdbddbe Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Thu Dec 10 01:52:39 2020 +0100 release 1.1.0 (Lightning-AI#5048) * release 1.1.0 * pep8 commit 05f25f3 Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Wed Dec 9 20:14:34 2020 +0100 update usage of deprecated checkpoint_callback (Lightning-AI#5006) * drop usage of deprecated checkpoint_callback * fix * fix commit ce91795 Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Wed Dec 9 20:13:57 2020 +0100 ref: clean config [1/n] add intermediate setters (Lightning-AI#4990) * add intermediate setters * show inputs * fix options * move * fix * less talk * fix * talk less * str * cases * rename Co-authored-by: chaton <thomas@grid.ai> commit 068502f Author: Francisco J. H. Heras <fjhheras@gmail.com> Date: Wed Dec 9 19:13:13 2020 +0000 Loss format from .3f to .3g in the tqdm (Lightning-AI#4972) Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> commit bcbba3b Author: Rohit Gupta <rohitgr1998@gmail.com> Date: Thu Dec 10 00:42:44 2020 +0530 Simplify GPU and TPU accelerator (Lightning-AI#5024) commit 90d1d9f Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Wed Dec 9 19:05:12 2020 +0100 drop deprecated reorder from AUC (Lightning-AI#5004) * drop deprecated reorder from AUC * chlog * fix * fix * simple * fix * fix * fix Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> commit 20b806a Author: chaton <thomas@grid.ai> Date: Wed Dec 9 16:31:18 2020 +0000 [feat] 3/n pp (Lightning-AI#5036) * add pp doc * udpate doc * update doc * update doc * Update docs * update doc * udpate * update doc * update doc * Formatting, update sharded zip link * Update docs/source/multi_gpu.rst Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Apply suggestions from code review * Reference directly to section Co-authored-by: SeanNaren <sean@grid.ai> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> commit 69725ad Author: Carlos Mocholí <carlossmocholi@gmail.com> Date: Wed Dec 9 16:48:46 2020 +0100 Add carmocca to core (Lightning-AI#5038) Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> commit cff2489 Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Wed Dec 9 15:53:49 2020 +0100 fix GH release badges (Lightning-AI#5040) * fix GH release badges * rtd commit ef8ef12 Author: chaton <thomas@grid.ai> Date: Wed Dec 9 12:56:51 2020 +0000 [feat] pp 2/n (Lightning-AI#5026) * Added changes for RPC plugin * Add missing kwargs * Fix code format * Loading refactors by introducing is_distributed var, fix optimizer step flow * Add rpc guard * Added docstrings and typing * resolve comments * Add additional rpc hook, refactor name of exit process hook for clarity * remove annotation * Modify behaviour to allow optional return, add test for rpc plugin * resolve tests * rename is_ddp_based * update * update for windows * update * resolve test * code smell * Added sequential plugin * resolve bug * update * cleanup * add Exception * resolve docs * Remove ddp support * Revert distributed -> ddp * Update pl_examples/basic_examples/conv_sequential_example.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update pl_examples/basic_examples/conv_sequential_example.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update pytorch_lightning/plugins/ddp_sequential_plugin.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Address code review points * Update pytorch_lightning/plugins/ddp_sequential_plugin.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Update pytorch_lightning/plugins/ddp_sequential_plugin.py Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * Add missing return * Fix formatting, add datamodule args * add small comment * resolve comments * resolve comments * update source for fairscale * update extras * remove staticmethod * resolve flake8 * Skip tests that are failing due to bug upstream with multiple optimizers and shard * update * update on comments * clean test * latest comments * remove old comments * add todo * Update version * update * resolve bugs * resolve bugs * update test * remove hanging test * Update pytorch_lightning/plugins/ddp_sequential_plugin.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * resolve on comments * Update pytorch_lightning/plugins/ddp_sequential_plugin.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * resolve on comments * Update pytorch_lightning/plugins/ddp_sequential_plugin.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Update pytorch_lightning/plugins/ddp_sequential_plugin.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Update pytorch_lightning/plugins/ddp_sequential_plugin.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Update pytorch_lightning/plugins/ddp_sequential_plugin.py Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * remove ImportError Co-authored-by: SeanNaren <sean@grid.ai> Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> commit 7d9784e Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Wed Dec 9 12:53:37 2020 +0100 adding missing changelogs (Lightning-AI#5019) * adding missing changelogs * Apply suggestions from code review Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> * Apply suggestions from code review Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> commit 6a99d95 Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Wed Dec 9 11:53:22 2020 +0100 fix ci: release (Lightning-AI#5037) commit e2c404b Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Wed Dec 9 10:59:44 2020 +0100 CI: update badges for release (Lightning-AI#5002) * fix images * not sleep * a0 * path * assets * assets * bitecode * rls * rls * badges * fix * org * drop * clean * codecov * fix * clean commit 53d7c95 Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Wed Dec 9 09:18:23 2020 +0100 drop usage of deprecated distributed_backend (Lightning-AI#5009) Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> commit 2c11d96 Author: Jirka Borovec <Borda@users.noreply.github.com> Date: Wed Dec 9 03:57:11 2020 +0100 replace pyright by mypy (Lightning-AI#5021) * drop pyright & add mypy * detail * name * fix * flake8 * ver Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> commit 127454a Author: Ananya Harsh Jha <ananya@pytorchlightning.ai> Date: Tue Dec 8 18:20:01 2020 -0500 All gatherwith grads (Lightning-AI#5012) * all_gather * ddp * horovod * grad tests * fixed ddp * ddp fixed, removed tpu, horovod for now * changelog * windows fix * windows fix * removed batch from ctx * all_gather * ddp * horovod * grad tests * fixed ddp * ddp fixed, removed tpu, horovod for now * changelog * windows fix * windows fix * removed batch from ctx * removed code duplication * merge Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> commit ee9b3fe Author: Sean Naren <sean.narenthiran@gmail.com> Date: Tue Dec 8 22:02:10 2020 +0000 [feat] pp 1/n (Lightning-AI#5016) * Added changes for RPC plugin * Add missing kwargs * Fix code format * Loading refactors by introducing is_distributed var, fix optimizer step flow * Add rpc guard * Added docstrings and typing * resolve comments * Add additional rpc hook, refactor name of exit process hook for clarity * remove annotation * Modify behaviour to allow optional return, add test for rpc plugin * resolve tests * rename is_ddp_based * update * update for windows * update * resolve test * code smell * Revert back to init_ddp_connection for backwards compat * Swap to explicit name for property * Add missing speed parity increase for CI variability, fix call counts for child process Co-authored-by: tchaton <thomas@grid.ai> commit ddd3eda Author: brett koonce <koonce@gmail.com> Date: Tue Dec 8 15:27:43 2020 -0600 docs: minor spelling tweaks (Lightning-AI#5022) commit 6d2aeff Author: Rohit Gupta <rohitgr1998@gmail.com> Date: Wed Dec 9 01:37:53 2020 +0530 fast_dev_run can be int (Lightning-AI#4629) * fast_dev_run can be int * pep * chlog * add check and update docs * logging with fdr * update docs * suggestions Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * fdr flush logs * update trainer.fast_dev_run * codefactor and pre-commit isort * tmp Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Roger Shieh <sh.rog@protonmail.ch> Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com> commit 79ae66d Author: maxjeblick <maxjeblick@users.noreply.github.com> Date: Tue Dec 8 18:19:55 2020 +0100 Initialize trainer with None (Lightning-AI#4847) Co-authored-by: Sean Naren <sean.narenthiran@gmail.com> Co-authored-by: chaton <thomas@grid.ai> Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>

Borda added feature Is an improvement or enhancement refactor priority: 1 Medium priority task productivity labels Dec 6, 2020

Borda added this to the 1.1 milestone Dec 6, 2020

Borda changed the title ~~ref: pre-clean - add intermediate setters~~ ref: pre-clean - add intermediate setters [1/n] Dec 6, 2020

tchaton approved these changes Dec 6, 2020

View reviewed changes

SeanNaren approved these changes Dec 6, 2020

View reviewed changes

Borda marked this pull request as ready for review December 6, 2020 18:14

Borda requested review from awaelchli, justusschock and williamFalcon as code owners December 6, 2020 18:14

Borda marked this pull request as draft December 6, 2020 19:13

Borda force-pushed the refactor/trainer-attribs branch 3 times, most recently from de28d2d to 7f0fb4b Compare December 6, 2020 21:12

Borda marked this pull request as ready for review December 6, 2020 21:12

Borda added the ready PRs ready to be merged label Dec 6, 2020

carmocca reviewed Dec 7, 2020

View reviewed changes

pytorch_lightning/utilities/__init__.py Outdated Show resolved Hide resolved

awaelchli reviewed Dec 7, 2020

View reviewed changes

pytorch_lightning/trainer/deprecated_api.py Outdated Show resolved Hide resolved

justusschock approved these changes Dec 7, 2020

View reviewed changes

Borda requested a review from awaelchli December 7, 2020 09:08

Borda changed the title ~~ref: pre-clean - add intermediate setters [1/n]~~ ref: clean config [1/n] add intermediate setters Dec 7, 2020

carmocca reviewed Dec 7, 2020

View reviewed changes

pytorch_lightning/utilities/__init__.py Outdated Show resolved Hide resolved

carmocca approved these changes Dec 7, 2020

View reviewed changes

carmocca reviewed Dec 7, 2020

View reviewed changes

tests/trainer/test_trainer.py Show resolved Hide resolved

williamFalcon requested changes Dec 8, 2020

View reviewed changes

pytorch_lightning/accelerators/accelerator.py Show resolved Hide resolved

Borda requested a review from williamFalcon December 8, 2020 19:43

edenlightning removed the ready PRs ready to be merged label Dec 8, 2020

Borda added the ready PRs ready to be merged label Dec 9, 2020

Borda added 11 commits December 9, 2020 15:56

add intermediate setters

854a40d

show inputs

f900423

fix options

46f56b9

move

be7c4b4

fix

9572bf9

less talk

d8d627e

fix

d845d6c

talk less

8738f13

str

d098923

cases

52225ae

rename

ecb2081

Borda force-pushed the refactor/trainer-attribs branch from 24bcfd8 to ecb2081 Compare December 9, 2020 14:57

Merge branch 'master' into refactor/trainer-attribs

2cfc8af

tchaton reviewed Dec 9, 2020

View reviewed changes

Merge branch 'master' into refactor/trainer-attribs

4549050

williamFalcon merged commit ce91795 into master Dec 9, 2020

Borda deleted the refactor/trainer-attribs branch December 9, 2020 21:02

Borda mentioned this pull request Dec 30, 2020

fix trainer distributed attributes #5303

Merged

12 tasks

mergify bot removed the ready PRs ready to be merged label Nov 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ref: clean config [1/n] add intermediate setters #4990

ref: clean config [1/n] add intermediate setters #4990

Borda commented Dec 6, 2020 •

edited

Loading

pep8speaks commented Dec 6, 2020 •

edited

Loading

tchaton left a comment

Borda commented Dec 6, 2020

Borda commented Dec 6, 2020

codecov bot commented Dec 6, 2020 •

edited

Loading

justusschock commented Dec 7, 2020

Borda commented Dec 7, 2020 •

edited

Loading

tchaton Dec 9, 2020

ref: clean config [1/n] add intermediate setters #4990

ref: clean config [1/n] add intermediate setters #4990

Conversation

Borda commented Dec 6, 2020 • edited Loading

What does this PR do?

Before submitting

PR review

Did you have fun?

pep8speaks commented Dec 6, 2020 • edited Loading

Comment last updated at 2020-12-09 19:11:03 UTC

tchaton left a comment

Choose a reason for hiding this comment

Borda commented Dec 6, 2020

Borda commented Dec 6, 2020

codecov bot commented Dec 6, 2020 • edited Loading

Codecov Report

justusschock commented Dec 7, 2020

Borda commented Dec 7, 2020 • edited Loading

tchaton Dec 9, 2020

Choose a reason for hiding this comment

Borda commented Dec 6, 2020 •

edited

Loading

pep8speaks commented Dec 6, 2020 •

edited

Loading

codecov bot commented Dec 6, 2020 •

edited

Loading

Borda commented Dec 7, 2020 •

edited

Loading