-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idwtn should allow coefficients to be set as None #291
Conversation
This change also makes is consistent with the existing idwt2 behavior
Codecov Report
@@ Coverage Diff @@
## master #291 +/- ##
==========================================
- Coverage 86.36% 86.26% -0.11%
==========================================
Files 21 21
Lines 3088 3086 -2
Branches 532 532
==========================================
- Hits 2667 2662 -5
- Misses 368 371 +3
Partials 53 53
Continue to review full report at Codecov.
|
I agree |
LGTM for |
Added an |
Merged, thanks @grlee77 |
The current behavior in
idwtn
does not match the description in the docstring when any of the values in thecoeffs
dictionary isNone
. This PR updates the behavior to match the docstring. This also makesidwtn
treatNone
coefficients in the same was asidwt2
.Previously
idwtn
raised an error if any coefficients were None.technically that is a change in behavior, but as it is a bug fix I don't think we should need a deprecation cycle?
closes gh-290