Remove six #63
Merged
Remove six #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 17, 2015 17:24
Only string_types was used in six.
`_check_mode_input` was the only user of six. It was only used to check the input of `MODES.from_object`, and raised a `TypeError` if a numeric mode was out of range or a mode object was not a string type. `MODES.from_object` raises a `ValueError` in these situations, and when the mode name string is not found. Now, `MODES.from_object` is wrapped in a function `_try_mode` that returns its result and fixes the type of any exception raised to keep the API the same. This is a candidate for cleanup after the API break. Part of issue PyWavelets#61
|
nice. this looks good to me I would encourage not merging one's own pull request unless it is a trivial documentation change or something. If it is something small like this and you are not getting feedback, I would just state something like "will merge in 2 days unless there are any objections". I will plan to merge this one on Monday or Tuesday to give some time for other feedback. |
I didn't realize six.py was the only thing in _tools, removing now as it contains nothing.
|
Nice, good to get rid of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick patch to get rid of six, as discussed in #61.
Pull request for travis, and for review to make sure I'm not doing anything stupid or stepping on toes.
If I'm OK to push small things like this in future let me know, and I'll stop bugging everybody else.