-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and test PyWavelets Pyodide wheels in CI #701
Build and test PyWavelets Pyodide wheels in CI #701
Conversation
Pyodide wheel builds are succeeding and tests are passing on my fork, see here: https://github.com/agriyakhetarpal/pywt/actions/runs/8003758318 |
Okay, so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @agriyakhetarpal, this looks good! Nice to have a Pyodide CI job that works.
Beyond the one inline comment, I thought I'd ask if you want to rewrite the commit history (e.g., one commit for the CI job, one for the npy->npz, one for the test changes, and one for the other unrelated bits) or if you want me to squash-merge it. Either way is fine with me.
Thanks for the prompt review, @rgommers! It did take a bit of back and forth with the experiments – I don't have a strong opinion on rewriting history as such; it would be great if we can squash merge the PR, it's much easier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
============================= test session starts ==============================
platform emscripten -- Python 3.11.3, pytest-8.0.1, pluggy-1.4.0
...
================= 1030 passed, 6 skipped in 115.83s (0:01:55) ==================
Okay, in it goes.
This PR adds and configures a CI job to test wasm32 wheels for Pywavelets compiled via the Emscripten toolchain. Almost all tests pass, and some of them are skipped because of the current lack of threading for Pyodide (please refer to pyodide/pyodide#237).
It is likely that Pyodide has issues with file system access which was evident through
OSError
s when trying to access.npy
files, it's likely that this is a bug and I shall file it accordingly in the Pyodide issue tracker. The current workaround that has been adopted in this PR is to save the arrays loaded from these.npy
files to compressed.npz
file formats, which do not cause issues related to file permissions.An
IS_WASM
check has been added to check for the platform and allowpytest
to skip the concurrency-based tests after collection, as noted above.