-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add disable_all_items
in View
#1199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense to also support lists of Item
objects into the exclusions param.
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
Co-authored-by: krittick <ben@krittick.net>
@27Saumya can you please implement this suggestion? Being able to pass the actual |
@krittick how that though like what shall I typehint? |
it should be a list of |
Then just use |
Perhaps it should only allow item types that can be disabled. |
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only disabling the things passed to the exclusions parameter, the exact opposite of what is wanted.
Was going to say, what's the point in the current script? It just disables all those in the list. |
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change should finish up the PR
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
Summary
disable_all_items
function inView
which disables all items. It has a kwarg (exclusions
)(Optional[List[int
]]) which ignores the specific index ofself.children
and disables the rest children.Checklist
type: ignore
comments were used, a comment is also left explaining why