Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forum channels support #1249

Merged
merged 22 commits into from
May 13, 2022
Merged

Forum channels support #1249

merged 22 commits into from
May 13, 2022

Conversation

BobDotCom
Copy link
Member

Summary

Implements forum channels

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@BobDotCom BobDotCom added discord limitation Limitation imposed by discord priority: high High Priority status: in progress Work in Progess feature Implements a feature Merge with squash documentation needed labels Apr 11, 2022
@BobDotCom BobDotCom added this to the v2.0 milestone Apr 11, 2022
@BobDotCom BobDotCom self-assigned this Apr 11, 2022
@Dorukyum Dorukyum mentioned this pull request Apr 17, 2022
Closed
7 tasks
plun1331
plun1331 reviewed Apr 18, 2022
View reviewed changes
discord/abc.py Outdated Show resolved Hide resolved
discord/channel.py Outdated Show resolved Hide resolved
discord/channel.py Outdated Show resolved Hide resolved
discord/channel.py Outdated Show resolved Hide resolved
@BobDotCom @plun1331
Update discord/channel.py
3046fb1 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
Lulalaby
Lulalaby requested changes Apr 21, 2022
View reviewed changes
discord/abc.py Outdated Show resolved Hide resolved
discord/channel.py Outdated Show resolved Hide resolved
discord/channel.py Outdated Show resolved Hide resolved
discord/channel.py Outdated Show resolved Hide resolved
Lulalaby
Lulalaby requested changes Apr 21, 2022
View reviewed changes
discord/channel.py Outdated Show resolved Hide resolved
discord/channel.py Outdated Show resolved Hide resolved
discord/channel.py Outdated Show resolved Hide resolved
@Lulalaby
Copy link
Member

@plun1331 you mean like that? (Review)

BobDotCom and others added 7 commits April 21, 2022 13:59
@BobDotCom @Lulalaby
Update discord/abc.py
5a73a3d 
Co-authored-by: Lala Sabathil <lala@pycord.dev>
@BobDotCom @Lulalaby
Update discord/channel.py
653053e 
Co-authored-by: Lala Sabathil <lala@pycord.dev>
@BobDotCom @Lulalaby
Update discord/channel.py
c2bc9fd 
Co-authored-by: Lala Sabathil <lala@pycord.dev>
@BobDotCom @Lulalaby
Update discord/channel.py
c3e0f81 
Co-authored-by: Lala Sabathil <lala@pycord.dev>
@BobDotCom @Lulalaby
Update discord/channel.py
74bcb2b 
Co-authored-by: Lala Sabathil <lala@pycord.dev>
@BobDotCom @Lulalaby
Update discord/channel.py
205552a 
Co-authored-by: Lala Sabathil <lala@pycord.dev>
@BobDotCom @Lulalaby
Update discord/channel.py
7b96490 
Co-authored-by: Lala Sabathil <lala@pycord.dev>
Lulalaby
Lulalaby previously approved these changes Apr 21, 2022
View reviewed changes
@plun1331
Copy link
Member

@plun1331 you mean like that? (Review)

looks fine yeah

@Lulalaby Lulalaby marked this pull request as ready for review April 22, 2022 16:51
@Lulalaby
Copy link
Member

@Pycord-Development/contributors
@Pycord-Development/maintainers

Someone needs to finish this for bob

@Lulalaby Lulalaby enabled auto-merge (squash) April 23, 2022 00:26
@plun1331
Copy link
Member

@Pycord-Development/contributors @Pycord-Development/maintainers

Someone needs to finish this for bob

List of what needs to be finished would be nice

@Lulalaby
Copy link
Member

Check dms

@WhoIsConch
Copy link
Contributor

Github has DMs?

@plun1331
Copy link
Member

Github has DMs?

no, discord does though

@plun1331 plun1331 mentioned this pull request Apr 27, 2022
Merged
7 tasks
@BobDotCom
Merge pull request #1298 from plun1331/forum-channels
0433dd4 
Add more forum channel/thread features
krittick
krittick reviewed May 1, 2022
View reviewed changes
discord/channel.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 1, 2022 •
edited
Loading

Codecov Report

Merging #1249 (90bef7f) into master (7ad078f) will decrease coverage by 0.08%.
The diff coverage is 25.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
- Coverage   33.47%   33.39%   -0.09%     
==========================================
  Files          93       93              
  Lines       17581    17718     +137     
==========================================
+ Hits         5886     5917      +31     
- Misses      11695    11801     +106
Flag Coverage Δ
pytest 33.39% <25.16%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
discord/http.py 22.97% <5.00%> (-0.44%) ⬇️
discord/guild.py 24.12% <15.00%> (-0.19%) ⬇️
discord/threads.py 31.31% <22.22%> (-0.63%) ⬇️
discord/channel.py 34.79% <25.80%> (-2.07%) ⬇️
discord/abc.py 23.12% <50.00%> (+0.09%) ⬆️
discord/flags.py 78.37% <100.00%> (+0.30%) ⬆️
discord/types/channel.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad078f...90bef7f. Read the comment docs.

@krittick krittick added upcoming discord feature Involves a feature not yet fully released by Discord and removed discord limitation Limitation imposed by discord labels May 6, 2022
@Lulalaby Lulalaby merged commit 6228d50 into master May 13, 2022
@Lulalaby Lulalaby deleted the forum-channels branch May 13, 2022 17:54
@Lulalaby Lulalaby mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 left review comments

@Lulalaby Lulalaby Lulalaby left review comments

@Dorukyum Dorukyum Dorukyum approved these changes

@krittick krittick krittick approved these changes

Assignees
No one assigned
Labels
documentation needed feature Implements a feature priority: high High Priority status: in progress Work in Progess upcoming discord feature Involves a feature not yet fully released by Discord
Projects
Pycord Releases
Status: No status
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@BobDotCom @Lulalaby @plun1331 @WhoIsConch @krittick @Dorukyum