Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ext.pages] Add Paginator.edit() method #1258

Merged
merged 9 commits into from
Apr 15, 2022
Merged

[ext.pages] Add Paginator.edit() method #1258

merged 9 commits into from
Apr 15, 2022

Conversation

krittick
Copy link
Contributor

Summary

This adds a new edit method to the Paginator class, allowing users to more easily edit an existing message with the paginator contents.

Properly fixes #1093

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@krittick krittick added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature Merge with squash ext.pages Relating to ext.pages labels Apr 13, 2022
@krittick krittick added this to the v2.0 milestone Apr 13, 2022
@krittick krittick self-assigned this Apr 13, 2022
@krittick krittick changed the title [ext.pages] Add Paginator.edit() method. [ext.pages] Add Paginator.edit() method Apr 13, 2022
Lulalaby
Lulalaby previously approved these changes Apr 13, 2022
View reviewed changes
Middledot
Middledot reviewed Apr 14, 2022
View reviewed changes
discord/ext/pages/pagination.py Outdated Show resolved Hide resolved
discord/ext/pages/pagination.py Outdated Show resolved Hide resolved
@krittick @Middledot
Update discord/ext/pages/pagination.py
cb58f63 
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
@krittick krittick requested review from Middledot and Lulalaby April 14, 2022 19:03
krittick and others added 2 commits April 14, 2022 12:30
@krittick @Middledot
Update discord/ext/pages/pagination.py
bf2ff8d 
Co-authored-by: Middledot <78228142+Middledot@users.noreply.github.com>
@krittick
Merge branch 'master' into pages-patch-4
ec19fe3
@krittick krittick requested a review from Middledot April 14, 2022 19:31
@BobDotCom BobDotCom enabled auto-merge April 14, 2022 21:03
@BobDotCom BobDotCom disabled auto-merge April 14, 2022 21:03
@BobDotCom BobDotCom enabled auto-merge (squash) April 14, 2022 21:04
@krittick krittick disabled auto-merge April 15, 2022 02:45
@krittick krittick merged commit 290b009 into Pycord-Development:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Middledot Middledot Middledot approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

@BobDotCom BobDotCom Awaiting requested review from BobDotCom

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

Assignees

@krittick krittick

Labels
ext.pages Relating to ext.pages feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: No status
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Add a way to pass an interaction for a paginator to update
3 participants
@krittick @Lulalaby @Middledot