Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new hooks/handlers to bridge commands #1411

Merged
merged 6 commits into from
Jun 29, 2022
Merged

Add new hooks/handlers to bridge commands #1411

merged 6 commits into from
Jun 29, 2022

Conversation

baronkobama
Copy link
Contributor

@baronkobama baronkobama commented Jun 11, 2022 •
edited
Loading

Summary

This PR adds the ability to utilize local error handlers, before-invoke hooks, and after-invoke hooks on bridge commands.

Closes #1388, closes #1399

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum

This comment was marked as outdated.

Sign in to view
@Lulalaby Lulalaby added Merge with squash ext.bridge Relating to ext.bridge feature Implements a feature labels Jun 27, 2022
@Lulalaby Lulalaby requested a review from Dorukyum June 27, 2022 07:26
Dorukyum
Dorukyum approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Dorukyum Dorukyum merged commit 13c567f into Pycord-Development:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees

@baronkobama baronkobama

Labels
ext.bridge Relating to ext.bridge feature Implements a feature
Projects
Pycord Releases
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ext.bridge] No Before and After Hooks [ext.bridge] Allow for local error handling w/ bridge commands.
3 participants
@baronkobama @Dorukyum @Lulalaby