Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated/incorrect endpoints #1426

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

baronkobama
Copy link
Contributor

Summary

This PR does two things:

  • Removes the deprecated endpoint /guilds/{guild_id}/members/@me/nick and replaces it with /guilds/{guild_id}/members/@me in HTTPClient.change_my_nickname.
  • Changes the incorrect POST HTTP method to the correct PUT HTTP method in HTTPClient.join_thread.

References:

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

Note

  • For some reason, it appears that the POST HTTP method does function for HTTPClient.join_thread, as well as PUT. Gonna go ahead and change to the currently documented method (PUT) anyways. 🤷

@Lulalaby Lulalaby requested review from krittick and Dorukyum June 16, 2022 00:15
@Dorukyum Dorukyum merged commit 9e3e69a into Pycord-Development:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants