Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Guild.region attribute #1429

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Remove Guild.region attribute #1429

merged 2 commits into from
Jun 18, 2022

Conversation

baronkobama
Copy link
Contributor

@baronkobama baronkobama commented Jun 18, 2022 •
edited
Loading

Summary

This PR removes Guild.region as it is now a deprecated attribute. The correct attribute to now use is VoiceChannel.rtc_region.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Lulalaby
Copy link
Member

Remove it ^^

@Lulalaby
Copy link
Member

This was long enough announced from discord.

@baronkobama baronkobama changed the title Add deprecation warning to Guild.region Remove Guild.region attribute Jun 18, 2022
@baronkobama
Copy link
Contributor Author

Remove it ^^

Done 👍

@Dorukyum Dorukyum enabled auto-merge (squash) June 18, 2022 07:43
@Dorukyum Dorukyum merged commit a982008 into Pycord-Development:master Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baronkobama @Lulalaby @Dorukyum