Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ForumChannelConverter #1440

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Implement ForumChannelConverter #1440

merged 3 commits into from
Jun 23, 2022

Conversation

Dorukyum
Copy link
Member

@Dorukyum Dorukyum commented Jun 23, 2022 •
edited
Loading

Summary

Suggested in the server, converter for forum channels.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...)

@Dorukyum Dorukyum marked this pull request as ready for review June 23, 2022 15:55
@Dorukyum Dorukyum added priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature labels Jun 23, 2022
@Dorukyum Dorukyum self-assigned this Jun 23, 2022
@Dorukyum Dorukyum added this to the v2.0 milestone Jun 23, 2022
@Lulalaby Lulalaby enabled auto-merge (squash) June 23, 2022 15:57
Lulalaby
Lulalaby approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lulalaby Lulalaby requested review from plun1331 and EmmmaTech June 23, 2022 15:58
@Lulalaby Lulalaby requested a review from Middledot June 23, 2022 16:03
@Lulalaby Lulalaby merged commit 943cc56 into Pycord-Development:master Jun 23, 2022
@Dorukyum Dorukyum deleted the forum-channel-converter branch June 23, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmmmaTech EmmmaTech EmmmaTech approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@krittick krittick krittick approved these changes

@plun1331 plun1331 Awaiting requested review from plun1331

@Middledot Middledot Awaiting requested review from Middledot

Assignees

@Dorukyum Dorukyum

Labels
feature Implements a feature priority: medium Medium Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: No status
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Dorukyum @krittick @Lulalaby @EmmmaTech