Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement app_permissions and fix stuff #1460

Merged
merged 18 commits into from
Jul 2, 2022
Merged

Implement app_permissions and fix stuff #1460

merged 18 commits into from
Jul 2, 2022

Conversation

Lulalaby
Copy link
Member

No description provided.

@Lulalaby Lulalaby enabled auto-merge (rebase) June 29, 2022 23:57
@Lulalaby Lulalaby self-assigned this Jun 29, 2022
@Lulalaby Lulalaby added priority: high High Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature Merge with rebase upcoming discord feature Involves a feature not yet fully released by Discord labels Jun 30, 2022
@Lulalaby Lulalaby added this to the v2.0 milestone Jun 30, 2022
@Lulalaby Lulalaby disabled auto-merge June 30, 2022 00:02
EmmmaTech
EmmmaTech reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@EmmmaTech EmmmaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

discord/types/interactions.py Show resolved Hide resolved
@Lulalaby Lulalaby changed the title Implement app_permissions Implement app_permissions and fix stuff Jun 30, 2022
@Lulalaby Lulalaby added bug Something isn't working documentation Improvements or additions to documentation labels Jun 30, 2022
baronkobama
baronkobama previously approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@baronkobama baronkobama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

discord/interactions.py Outdated Show resolved Hide resolved
@Lulalaby @baronkobama
Update discord/interactions.py
e89ad9e 
Co-authored-by: baronkobama <baronkobama@gmail.com>
@Lulalaby Lulalaby enabled auto-merge (squash) June 30, 2022 00:33
plun1331
plun1331 previously approved these changes Jun 30, 2022
View reviewed changes
EmmmaTech
EmmmaTech previously approved these changes Jun 30, 2022
View reviewed changes
@Lulalaby Lulalaby disabled auto-merge June 30, 2022 04:26
@Lulalaby Lulalaby enabled auto-merge (squash) June 30, 2022 04:26
@Lulalaby Lulalaby linked an issue Jun 30, 2022 that may be closed by this pull request
commands.bot_has_permissions doesn't work for slash or bridge commands in dms #1421
Closed
3 tasks
@Lulalaby Lulalaby dismissed stale reviews from EmmmaTech and plun1331 via 0a48ada June 30, 2022 11:46
@Lulalaby
Copy link
Member Author

TODO for commands core:
The permissions check can, if it's a application command, directly get the permissions from the property app_permissions.

plun1331
plun1331 reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should make the necessary changes to the commands core permission check to use app_permissions

Also changed app_permissions to be a cached slot property thingy on Interaction

discord/ext/commands/core.py Outdated Show resolved Hide resolved
discord/ext/commands/core.py Outdated Show resolved Hide resolved
discord/interactions.py Outdated Show resolved Hide resolved
discord/interactions.py Show resolved Hide resolved
Lulalaby and others added 4 commits June 30, 2022 17:24
@Lulalaby @plun1331
Update discord/ext/commands/core.py
6ddd453 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
@Lulalaby @plun1331
Update discord/ext/commands/core.py
2fa70ad 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
@Lulalaby @plun1331
Update discord/interactions.py
f0f9030 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
@Lulalaby @plun1331
Update discord/interactions.py
7fb3e52 
Co-authored-by: plun1331 <49261529+plun1331@users.noreply.github.com>
@Lulalaby
Copy link
Member Author

I hate GitHub mobile

Thanks @plun1331

@Lulalaby Lulalaby merged commit e44dd80 into master Jul 2, 2022
@BobDotCom BobDotCom deleted the app_permissions branch October 7, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 left review comments

@Middledot Middledot Middledot approved these changes

@Dorukyum Dorukyum Dorukyum approved these changes

@baronkobama baronkobama baronkobama left review comments

@EmmmaTech EmmmaTech EmmmaTech left review comments

Assignees

@Lulalaby Lulalaby

Labels
bug Something isn't working documentation Improvements or additions to documentation feature Implements a feature priority: high High Priority status: awaiting review Awaiting review from a maintainer upcoming discord feature Involves a feature not yet fully released by Discord
Projects
Pycord Releases
Status: Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

commands.bot_has_permissions doesn't work for slash or bridge commands in dms
6 participants
@Lulalaby @plun1331 @EmmmaTech @Dorukyum @baronkobama @Middledot