Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update thread.members on thread.fetch_members #1464

Merged
merged 1 commit into from
Jul 3, 2022
Merged

Update thread.members on thread.fetch_members #1464

merged 1 commit into from
Jul 3, 2022

Conversation

Snawe
Copy link
Contributor

@Snawe Snawe commented Jul 3, 2022

Summary

On thread.fetch_members() the thread.members attribute wasn't updated which results in the need of always using thread.fetch_members() instead of relying on the cache afterwards.

Checklist

  • If code changes were made then they have been tested.

@Lulalaby Lulalaby enabled auto-merge (rebase) July 3, 2022 15:08
@Lulalaby Lulalaby added bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer Merge with rebase labels Jul 3, 2022
@Lulalaby Lulalaby added this to the v2.0 milestone Jul 3, 2022
@Lulalaby Lulalaby merged commit 9dc433a into Pycord-Development:master Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees
No one assigned
Labels
bug Something isn't working priority: high High Priority status: awaiting review Awaiting review from a maintainer
Projects
Pycord Releases
Status: Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Snawe @Lulalaby @Dorukyum