Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement app_commands_badge in flags.py #1535

Merged
merged 2 commits into from
Jul 30, 2022
Merged

Implement app_commands_badge in flags.py #1535

merged 2 commits into from
Jul 30, 2022

Conversation

lol219
Copy link
Contributor

@lol219 lol219 commented Jul 30, 2022

Summary

This pull requests adds a new app_commands_badge flag in flags.py

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

Lulalaby
Lulalaby previously approved these changes Jul 30, 2022
View reviewed changes
@Lulalaby Lulalaby enabled auto-merge (rebase) July 30, 2022 18:41
@Lulalaby Lulalaby requested a review from Dorukyum July 30, 2022 18:41
@Lulalaby Lulalaby added the feature Implements a feature label Jul 30, 2022
Dorukyum
Dorukyum requested changes Jul 30, 2022
View reviewed changes
discord/flags.py Outdated Show resolved Hide resolved
@lol219 @Dorukyum
Update discord/flags.py
798330a 
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
auto-merge was automatically disabled July 30, 2022 19:08

Head branch was pushed to by a user without write access

Dorukyum
Dorukyum approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@Dorukyum Dorukyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Dorukyum Dorukyum enabled auto-merge (squash) July 30, 2022 19:11
@Lulalaby Lulalaby disabled auto-merge July 30, 2022 19:12
@Lulalaby Lulalaby merged commit 89d20ce into Pycord-Development:master Jul 30, 2022
@Dorukyum Dorukyum mentioned this pull request Aug 7, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dorukyum Dorukyum Dorukyum approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees
No one assigned
Labels
feature Implements a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lol219 @Lulalaby @Dorukyum