Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RPC endpoint support (Client.fetch_application) #1536

Merged
merged 11 commits into from
Jul 31, 2022

Conversation

lol219
Copy link
Contributor

@lol219 lol219 commented Jul 30, 2022

Summary

This PR adds a fetch_application() method to client.py and a matching get_application() in http.py.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

lol219 and others added 4 commits July 30, 2022 19:34
discord/http.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@lol219 lol219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

discord/flags.py Outdated Show resolved Hide resolved
Lulalaby
Lulalaby previously approved these changes Jul 30, 2022
@Lulalaby Lulalaby added the feature Implements a feature label Jul 30, 2022
@lol219
Copy link
Contributor Author

lol219 commented Jul 30, 2022

thank you for fixing these errors lol i was about to update them

@Lulalaby Lulalaby added the undocumented discord feature This isn't documented, might not receive support for it! label Jul 30, 2022
@Lulalaby Lulalaby requested review from EnokiUN and Dorukyum and removed request for EnokiUN July 30, 2022 20:01
@Lulalaby Lulalaby enabled auto-merge (squash) July 30, 2022 20:02
Lulalaby
Lulalaby previously approved these changes Jul 30, 2022
discord/client.py Outdated Show resolved Hide resolved
Lulalaby
Lulalaby previously approved these changes Jul 30, 2022
@Dorukyum Dorukyum disabled auto-merge July 31, 2022 10:41
@Dorukyum Dorukyum merged commit ea4452e into Pycord-Development:master Jul 31, 2022
@searchify7
Copy link

searchify7 commented Jul 31, 2022

Yep also we need to make a code example of how to use it, maybe?
@Lulalaby @Dorukyum @lol219

@lol219
Copy link
Contributor Author

lol219 commented Jul 31, 2022

yes , why not .

@Dorukyum
Copy link
Member

Yep also we need to make a code example of how to use it, maybe?

This is only a function, the docs should be enough.

@searchify7
Copy link

Yep also we need to make a code example of how to use it, maybe?

This is only a function, the docs should be enough.

Yeah you're right but other people can't understand how to use it

Copy link
Contributor Author

@lol219 lol219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh I think we forgot version added in documentation @Lulalaby @Dorukyum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Implements a feature undocumented discord feature This isn't documented, might not receive support for it!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants