Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sticker creation checks #1546

Merged
merged 8 commits into from
Aug 6, 2022
Merged

Improve sticker creation checks #1546

merged 8 commits into from
Aug 6, 2022

Conversation

Middledot
Copy link
Member

Summary

Fix #1540

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Middledot Middledot added bug Something isn't working priority: high High Priority labels Aug 5, 2022
@Middledot Middledot requested review from Lulalaby and Dorukyum August 5, 2022 22:16
@Lulalaby
Copy link
Member

Lulalaby commented Aug 6, 2022

But description is optional..

@Middledot Middledot changed the title Make sticker description required Improve sticker creation checks Aug 6, 2022
@Middledot
Copy link
Member Author

Corrected, misread the docs

@Lulalaby Lulalaby enabled auto-merge (squash) August 6, 2022 16:19
Lulalaby
Lulalaby previously approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Lulalaby
Lulalaby approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh the doc string xD

@Lulalaby Lulalaby merged commit 8731e1f into Pycord-Development:master Aug 6, 2022
@Middledot Middledot deleted the fix-stickers branch August 6, 2022 23:02
@kilgoreandy
Copy link

TYVM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Assignees
No one assigned
Labels
bug Something isn't working priority: high High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ctx.guild.create_sticker yields 400 bad request when optional parameter description is not used.
4 participants
@Middledot @Lulalaby @kilgoreandy @ChickenDevs