Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SelectOption.emoji a property #1550

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Make SelectOption.emoji a property #1550

merged 1 commit into from
Aug 6, 2022

Conversation

Middledot
Copy link
Member

Summary

Makes emoji a property of SelectOption so that emoji's can be validated when set.
Resolves #1499

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

@Middledot Middledot added bug Something isn't working feature Implements a feature labels Aug 6, 2022
@Lulalaby Lulalaby enabled auto-merge (rebase) August 6, 2022 22:53
@lol219
Copy link
Contributor

lol219 commented Aug 6, 2022

So it's a Bug fix

@Lulalaby Lulalaby merged commit 81a8621 into Pycord-Development:master Aug 6, 2022
@Middledot Middledot deleted the fix-select-option-emoji branch August 6, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lol219 lol219 lol219 approved these changes

@ChickenDevs ChickenDevs ChickenDevs approved these changes

@Lulalaby Lulalaby Lulalaby approved these changes

Assignees
No one assigned
Labels
bug Something isn't working feature Implements a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting the emoji property of a SelectOption after initialization raises an exception when sending it
4 participants
@Middledot @lol219 @Lulalaby @ChickenDevs