Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply cog_check method to ApplicationCommand invocations #1575

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

NeloBlivion
Copy link
Member

Summary

Essentially copies over the cog_check implementation from ext.commands to allow it to run when an application command is invoked.
There was a large PR #640 that would work on a larger scale some months ago, however it was closed due to permission changes. This code addition is relatively minor and as such hopefully shouldn't conflict with any other plans.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.

Copy link
Contributor

@baronkobama baronkobama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lulalaby Lulalaby enabled auto-merge (squash) August 23, 2022 19:43
@Lulalaby Lulalaby requested a review from Dorukyum August 23, 2022 19:44
@Lulalaby Lulalaby merged commit 8475f90 into Pycord-Development:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants